tflobbe commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794920272
##########
File path:
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
##########
@@ -75,6 +76,15 @@ public static void withServerIdentity(final boolean enabled)
{
}
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ /**
+ * If a number has less than this number of digits, it'll not be considered
a timestamp.
+ */
+ private static final int MIN_TIMESTAMP_DIGITS = 10; // a timestamp of
9999999999 is year 1970
Review comment:
Yes, I thought about this too. At the end, I decided to keep the limits
pretty open to handle only the bad parsing edge case, and let the regular
expiration code handle the case where there is in fact a number. I'm happy to
change the limits if you think it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
