haythemkh opened a new pull request #584: URL: https://github.com/apache/solr/pull/584
https://issues.apache.org/jira/browse/SOLR-15342 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Please provide a short description of the changes you're making with this pull request. - Added a new module solrj-zookeeper and transferred Solrj's ZooKeeper dependency to it. - Extraction of the utility methods of Solrj dependent on ZK in a new class ZkUtils. - Extracted _PerReplicaStates fetch(String, SolrZkClient, PerReplicaStates)_ from _PerReplicaStates_ so as not to have to move the entire class but only the method dependent on ZK. - Copied the constants of ZkStateReader and of ImplicitSnitch on which the classes depend in their interior. - Creation of the ZkStateReader#from method replacing CloudSolrClient#getZkStateReader. - Created the CloudSolrClientUtils class grouping the ZK utility methods of CloudSolrClient - Added ClusterStateProvider#getQuorumHosts method for getting ZK hosts - Applied reflection for the instantiation of the class ZkClientClusterStateProvider in CloudHttp2SolrClient and CloudSolrClient. - Created NodesSysProps interface - Remains to be done: solve the nocommit and align the tests. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
