ben-manes commented on a change in pull request #580:
URL: https://github.com/apache/solr/pull/580#discussion_r797197119
##########
File path:
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java
##########
@@ -89,6 +86,21 @@ public TransientSolrCoreCacheDefault(CoreContainer
coreContainer) {
transientDescriptors = new LinkedHashMap<>(initialCapacity);
}
+ private void onEvict(SolrCore core) {
+ if (core.getOpenCount() > 1) {
Review comment:
That's make sense. I think informing the cache that the entry's state
changed is desirable for managing resources, but understandably hard as
projects evolve without that behavior in mind. If you obtain metrics that
indicate a problem then it will be interesting to discuss our options. I think
your approach is pretty good as a workaround and sounds safe enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
