Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r799607786
##########
File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
##########
@@ -229,19 +230,19 @@ public static void createJoinField(FacetRequest.Domain
domain, Map<String,Object
* Creates a Query that can be used to recompute the new "base" for this
domain, relative to the
* current base of the FacetContext.
*/
- public Query createDomainQuery(FacetContext fcontext) throws IOException
{
+ public Query createDomainQuery(FacetContext fcontext) {
// NOTE: this code lives here, instead of in
FacetProcessor.handleJoin, in order to minimize
// the number of classes that have to know about the number of
possible settings on the join
// (ie: if we add a score mode, or some other modifier to how the
joins are done)
- final SolrConstantScoreQuery fromQuery = new
SolrConstantScoreQuery(fcontext.base.getTopFilter());
+ final ConstantScoreQuery fromQuery = new
ConstantScoreQuery(fcontext.base.makeQuery());
Review comment:
Refactored it so `fromQuery` is not wrapped in a constant score query
given we are using makeQuery which is a constant scoring query 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
