[
https://issues.apache.org/jira/browse/SOLR-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489105#comment-17489105
]
Kevin Risden commented on SOLR-15992:
-------------------------------------
slf4j is from the PR for SOLR-15987 - I had to build on top of it since it
touches the same files. They are separate commits and once SOLR-15987 is merged
will make sure the PR is addressed.
@Nullable, @NonNull, and anything from javax.annotation - comes from jsr305.
There are very few usages in our code base and even if they are useful, jsr305
is forbidden due to licensing - it is GPL - so we shouldn't keep using it. It
is in 3 source files in core and one test file in core. So the annotations
aren't even consistently applied. For the files that are touched, they were
very simple usages and not even core to the Solr project. If you feel that
strongly about removing jsr305 and @Nullable then sure can take it up on the
dev list, but I don't see the big impact here.
> Globally forbid and exclude known bad dependencies
> --------------------------------------------------
>
> Key: SOLR-15992
> URL: https://issues.apache.org/jira/browse/SOLR-15992
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There are some known dependencies that we don't want to include in the
> project like:
> * commons-logging since we use slf4j
> * jsr305 - since there are license issues
> This should be accomplished globally so we don't need to do this in each
> module.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
