bruno-roustant commented on a change in pull request #608:
URL: https://github.com/apache/solr/pull/608#discussion_r804539688



##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexWriter.java
##########
@@ -176,14 +176,18 @@ private SolrIndexWriter(SolrCore core, String name, 
String path, Directory direc
     }
   }
 
+  public static void setCommitData(IndexWriter iw, long commitCommandVersion) {

Review comment:
       The call from DirectUpdateHandler2.closeWriter() can provide a null 
param.
   The call from SolrIndexSplitter.doSplit() actually I'm wondering now if it 
should set the custom user metadata by copying it from the latest commit of the 
core being split.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to