dsmiley commented on pull request #601: URL: https://github.com/apache/solr/pull/601#issuecomment-1036934788
I found the lifecycle of these "proc" instances in this code to not be as clear as I'd like. And I saw that finish() was being called after each document (when parallel replay) which doesn't sound nice, (may cause excessive `fsync`). I also don't love that these proc's would then be created for each doc. So I fixed all these matters by using a ThreadLocal scoped to this processing to hold the proc. They need to be be kept in a list so they can all be `finish()`'ed and `close()`'ed at the end. WDYT? Tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
