dsmiley commented on a change in pull request #638:
URL: https://github.com/apache/solr/pull/638#discussion_r806440724
##########
File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java
##########
@@ -68,7 +74,7 @@ public String toString(String field) {
@Override
public void visit(QueryVisitor visitor) {
- q.visit(visitor);
+ q.visit(visitor.getSubVisitor(BooleanClause.Occur.FILTER, this));
Review comment:
CSQ does this; makes sense.
##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -2075,12 +2075,10 @@ public int numDocs(Query a, DocSet b) throws
IOException {
return a == absQ ? b.intersectionSize(positiveA) :
b.andNotSize(positiveA);
} else {
// If there isn't a cache, then do a single filtered query
- // NOTE: we cannot use FilteredQuery, because BitDocSet assumes it will
never
Review comment:
obsolete comment; FilteredQuery hasn't existed in quite some time, and
even then I'm a bit confused by the comment as this doesn't use UninvertedField
so who cares.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
