risdenk commented on a change in pull request #637:
URL: https://github.com/apache/solr/pull/637#discussion_r806853966
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##########
@@ -1298,6 +1298,16 @@ public static ModifiableSolrParams params(String...
params) {
return Utils.makeMap(params);
}
+ public static SolrParams mapParams(String... vals) {
Review comment:
Yea I want to make this change outside of this PR. `mapParams` is being
used across classes for no good reason. I agree it needs to move somewhere and
its a weird method. I'll see where else in `test-framework` makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
