risdenk commented on pull request #636: URL: https://github.com/apache/solr/pull/636#issuecomment-1040582962
Chatted w/ @HoustonPutman on Slack about this and there is a bit of confusion. > noticed that the Krb5HttpClientBuilder was moved to this module, from SolrJ. It doesn't look like it has any of these hadoop dependencies, so it would likely be better to keep it in SolrJ so clients could continue to use it? `Krb5HttpClientBuilder` was NOT moved. `Krb5HttpClientUtils` WAS moved. The naming is super confusing. Some additional info regarding `Krb5HttpClientUtils`: * it is only used by the `hadoop-auth` stuff. specifically `TestRuleBasedAuthorizationWithKerberos`. * I can't leave `Krb5HttpClientUtils` in `solrj` since Gradle doesn't export the test classes to be used in other projects. * `Krb5HttpClientUtils` uses `Http2SolrClient#getHttpClient()` so it needs to be in that package to be accessible. :( * so I think where `Krb5HttpClientUtils` now lives in the PR is correct and `Krb5HttpClientBuilder` should not be moved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
