dsmiley commented on a change in pull request #658:
URL: https://github.com/apache/solr/pull/658#discussion_r810448586
##########
File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java
##########
@@ -81,6 +81,9 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode
scoreMode, float bo
return new ConstantScoreWeight(this, boost) {
@Override
public Scorer scorer(LeafReaderContext context) {
+ if (docSet == null) {
Review comment:
How could docSet be null? I think it can't; and if I'm right we should
maybe even use `Objects.requireNonNull ` in the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
