magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1048064685
Thanks again David and Mike; I just wanted to call out one minor change (in 1b4d7d1a380ae420ea99328929e8b7b52e9a0e33): instead of throwing an IllegalArgumentException upon attempting FilterQuery.setCache(true), we now silently ignore this _at the implementation level_, considering that because of what FilterQuery _is_, the higher-level semantics of `setCache(...)` are actually better respected by a lenient approach. I've added a detailed comment in the `setCache()` method, and built out the test method to cover related cases. I plan to commit tomorrow, pending further feedback/concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
