janhoy commented on a change in pull request #688:
URL: https://github.com/apache/solr/pull/688#discussion_r812446036



##########
File path: solr/server/scripts/cloud-scripts/snapshotscli.sh
##########
@@ -11,7 +11,7 @@ run_solr_snapshot_tool() {
     log4j_config="file:${scriptDir}/../../resources/log4j2-console.xml"
   fi
   PATH=${JAVA_HOME}/bin:${PATH} ${JVM} ${ZKCLI_JVM_FLAGS} 
-Dlog4j.configurationFile=${log4j_config} \
-  -classpath "${solrLibPath}" org.apache.solr.core.snapshots.SolrSnapshotsTool 
"$@" 2> /dev/null
+  -classpath "${solrLibPath}" org.apache.solr.hdfs.snapshots.SolrSnapshotsTool 
"$@" 2> /dev/null

Review comment:
       Do we need to add modules/hdfs/... to `solrLibPath` for this tool to 
work? Why did the SolrSnapshotsTool need to move to hdfs module in the first 
plae?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to