risdenk commented on a change in pull request #691: URL: https://github.com/apache/solr/pull/691#discussion_r812502226
########## File path: gradle/validation/owasp-dependency-check/exclusions.xml ########## @@ -23,43 +23,32 @@ <suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd";> <suppress> - <notes><![CDATA[ - file name: simple-xml-safe-2.7.1.jar - We use a safe fork that fixes this - ]]></notes> + <notes><![CDATA[simple-xml-safe is a safe xml-safe fork]]></notes> <packageUrl regex="true">^pkg:maven/com\.carrotsearch\.thirdparty/simple\-xml\-safe@.*$</packageUrl> <cve>CVE-2017-1000190</cve> </suppress> <suppress> - <notes><![CDATA[ - file name: netty-transport-native-epoll-4.1.29.Final.jar - We only use netty as a client towards Zookeeper - ]]></notes> - <packageUrl regex="true">^pkg:maven/io\.netty/netty\-.*@.*$</packageUrl> - <cpe>cpe:/a:netty:netty</cpe> Review comment: FWIW this was really wrong - since this is basically saying netty isn't identified as netty - which is untrue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
