[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497844#comment-17497844
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
[~dsmiley] I totally agree that spotless sometimes leads to unaesthetic
results that could be improved. The question is whether those improvements
should be made as part of this massive reformatting with the attendant delay
and effort or just left as Spotless modifies them until someone who's working
on the code for other reasons has reason to neaten it up.
There are 3,400 files or so and about a zillion reformatted lines. At this
scale, trying to examine each change and figure out whether/how to do it better
is error-prone. Mixing whole-file reformatting, especially at this scale, with
code changes is a recipe for making any code changes that actually mess
something up nearly impossible to find in the noise, made worse if we skip this
revision for git blame.....
My $0.02 anyway. This effort has languished for over a 18 months, so I keep
repeating to myself "progress, not perfection"...
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
