[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499782#comment-17499782
]
Kevin Risden commented on SOLR-14920:
-------------------------------------
Ok minus the minor hiccup around XMLResponseParser - things seem to still be
good :D
solr core test only has been merged to branch_9x and main. I will plan to merge
to branch_9_0 tomorrow (have that staged locally)
solr core non test - https://github.com/apache/solr/pull/705 - is almost ready
for review. I am halfway through making changes and should have them later
today or early tomorrow.
With the above that would only leave
"solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/" with an
exception. [~erickerickson] do you want to tackle that specifically? It is the
TEST specific files there. Its not many files, but the files have a lot of
formatted json and its ugly when it goes through spotless.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Kevin Risden
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
