[
https://issues.apache.org/jira/browse/SOLR-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500954#comment-17500954
]
David Smiley commented on SOLR-14401:
-------------------------------------
Thanks for looking Jan!
Notice the PR removes the prometheus exported metrics names that had "local" in
their names e.g. there was one that had {{local_count}} in its name and others.
The rationale – you can filter by tags, which consumers should probably be
doing _any way_ as the handlers are for different purposes.
RE the regexp, yeah, maybe the JQ {{core-template}} could do one of two things:
* add a new label like {{internal=shard}} vs {{internal=false}} when it's not?
In time maybe we'd have different values that are more interesting? Or just
keep it simple – shard=true/false
* replace {{[shard]}} with {{_shard}} or something? or double-underscore to
make it clearer this is special/internal?
* The above but at the Solr layer and not in JQ
> "distrib" request handler metrics should only be tracked on pertinent handlers
> ------------------------------------------------------------------------------
>
> Key: SOLR-14401
> URL: https://issues.apache.org/jira/browse/SOLR-14401
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> SOLR-13979 in 8.4 added separate request handler metrics for distributed
> requests. However this was done for _all_ request handlers, even though it's
> mainly SearchHandler (and maybe one or two others?) where a distributed
> request is even possible. I refer to this as "metrics pollution" and it's a
> bad thing. It's more weight per handler (latency load & memory), more weight
> for Solr metrics responses, and it's also _suggestive_ that all registered
> handlers can have distributed requests when this is quite false, thus
> confusing people.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
