madrob commented on a change in pull request #734:
URL: https://github.com/apache/solr/pull/734#discussion_r825166570
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -697,12 +694,6 @@ public synchronized void stop() throws Exception {
timeout.waitFor("Timeout waiting for reserved executor to stop.",
rte::isStopped);
}
- // we want to shutdown outside of jetty cutting us off
- SolrDispatchFilter sdf = getSolrDispatchFilter();
- if (sdf != null) {
- ExecutorUtil.shutdownAndAwaitTermination(getJettyShutDownThreadPool());
Review comment:
This looks dubious (the code, not the removal) but I'm unclear if that's
the same bug you're addressing here or a separate problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
