madrob commented on a change in pull request #654:
URL: https://github.com/apache/solr/pull/654#discussion_r826528588
##########
File path:
solr/core/src/test/org/apache/solr/rest/TestManagedResourceStorage.java
##########
@@ -116,7 +103,7 @@ private void doStorageTests(SolrResourceLoader loader,
StorageIO storageIO) thro
assertEquals("true", storedArgs.get("ignoreCase"));
List<String> storedList =
(List<String>)storedMap.get(ManagedResource.MANAGED_JSON_LIST_FIELD);
assertNotNull(storedList);
- assertTrue(storedList.size() == managedList.size());
+ assertEquals(storedList.size(), managedList.size());
Review comment:
nit: I think managedList is the expected value, swap the order of these
arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
