HoustonPutman commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834511425
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
##########
@@ -57,6 +57,7 @@
* All Solr ZooKeeper interactions should go through this class rather than
ZooKeeper. This class
* handles synchronous connects and reconnections.
*/
+// The constructor overloads are a little awkward, it would be nice to move
this to a builder
Review comment:
100%
##########
File path: solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java
##########
@@ -149,8 +152,7 @@ public void expireSession(final JettySolrRunner jetty) {
if (cores != null) {
monkeyLog("expire session for " + jetty.getLocalPort() + " !");
causeConnectionLoss(jetty);
- long sessionId =
cores.getZkController().getZkClient().getSolrZooKeeper().getSessionId();
- zkServer.expire(sessionId);
+
cores.getZkController().getZkClient().getZooKeeper().getTestable().injectSessionExpiration();
Review comment:
do we not need to expire on the server as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
