sonatype-lift[bot] commented on a change in pull request #760:
URL: https://github.com/apache/solr/pull/760#discussion_r834604185
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerRoleCmd.java
##########
@@ -76,11 +76,11 @@ public void call(ClusterState state, ZkNodeProps message,
NamedList<Object> resu
String roleName = message.getStr("role");
boolean nodeExists = false;
- if (nodeExists = zkClient.exists(ZkStateReader.ROLES, true)) {
+ if (nodeExists = zkClient.exists(ZkStateReader.ROLES)) {
Review comment:
*LogicalAssignment:* Assignment where a boolean expression was
expected; use == if this assignment wasn't expected or add parentheses for
clarity. [(details)](https://errorprone.info/bugpattern/LogicalAssignment)
```suggestion
if ((nodeExists = zkClient.exists(ZkStateReader.ROLES))) {' or 'if
(nodeExists == zkClient.exists(ZkStateReader.ROLES)) {
```
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with
`help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
