[GitHub] [solr] cpoerschke commented on a change in pull request #750: SOLR-15223 BaseCloudSolrClient is the new CloudSolrClient

[GitBox]

cpoerschke commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r834644743



##########
File path: 
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -230,122 +166,1272 @@ public Builder(ClusterStateProvider stateProvider) {
      * <pre>
      *   final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *   zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); 
zkServers.add("zookeeper3:2181");
-     *   final SolrClient client = new CloudSolrClient.Builder(zkServers, 
Optional.empty()).build();
+     *   final SolrClient client = new CloudHttp2SolrClient.Builder(zkServers, 
Optional.empty()).build();
      * </pre>
      *
      * Usage example when Solr data is stored in a ZooKeeper chroot:
      *
      * <pre>
      *    final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *    zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); 
zkServers.add("zookeeper3:2181");
-     *    final SolrClient client = new CloudSolrClient.Builder(zkServers, 
Optional.of("/solr")).build();
+     *    final SolrClient client = new 
CloudHttp2SolrClient.Builder(zkServers, Optional.of("/solr")).build();

Review comment:
       ```suggestion
        *    final SolrClient client = new CloudSolrClient.Builder(zkServers, 
Optional.of("/solr")).build();
   ```

##########
File path: 
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -209,16 +150,11 @@ protected Builder() {}
      * <pre>
      *   final List&lt;String&gt; solrBaseUrls = new ArrayList&lt;String&gt;();
      *   solrBaseUrls.add("http://solr1:8983/solr";); 
solrBaseUrls.add("http://solr2:8983/solr";); 
solrBaseUrls.add("http://solr3:8983/solr";);
-     *   final SolrClient client = new 
CloudSolrClient.Builder(solrBaseUrls).build();
+     *   final SolrClient client = new 
CloudHttp2SolrClient.Builder(solrBaseUrls).build();

Review comment:
       ```suggestion
        *   final SolrClient client = new 
CloudSolrClient.Builder(solrBaseUrls).build();
   ```

##########
File path: 
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##########
@@ -230,122 +166,1272 @@ public Builder(ClusterStateProvider stateProvider) {
      * <pre>
      *   final List&lt;String&gt; zkServers = new ArrayList&lt;String&gt;();
      *   zkServers.add("zookeeper1:2181"); zkServers.add("zookeeper2:2181"); 
zkServers.add("zookeeper3:2181");
-     *   final SolrClient client = new CloudSolrClient.Builder(zkServers, 
Optional.empty()).build();
+     *   final SolrClient client = new CloudHttp2SolrClient.Builder(zkServers, 
Optional.empty()).build();

Review comment:
       ```suggestion
        *   final SolrClient client = new CloudSolrClient.Builder(zkServers, 
Optional.empty()).build();
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org