janhoy opened a new pull request, #797:
URL: https://github.com/apache/solr/pull/797

   When we convert CHANGES.txt to Changes.html, we support adding href links to 
text like "Pull Request #123". I counted and we only use it like 2 times, and 
both of those were incorrect, so I removed them.
   
   NB: Perhaps we should allow a pattern like this as well, so you can add PRs 
to CHANGES without a JIRA:
   
   ```
   * #794 Fix a bug
   ```
   
   I.e. in addition to the pattern 
`((?:(?:(?:github|gh)\s+)?pull\s+request\s*(?:\#?\s*)?|gh-)(\d+))` also support 
`^\*\s+\#\d{1..4}`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to