anshumg commented on code in PR #802:
URL: https://github.com/apache/solr/pull/802#discussion_r847793281
##########
solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
##########
@@ -70,7 +70,7 @@ public String getClientString() {
// if the string wasn't passed as zkHost, then use the standalone server
we started
if (zkRun == null) return null;
- return "localhost:" + zkProps.getClientPortAddress().getPort();
+ return zkProps.getClientPortAddress().getHostString() + ":" +
zkProps.getClientPortAddress().getPort();
Review Comment:
LGTM. I was trying to see if we need to switch to using
zkProps.getSecureClientPortAddress optionally but couldn't find anything in the
ZK javadocs. Also, based on my ZK TLS testing - didn't seem like that was
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
