janhoy commented on code in PR #827:
URL: https://github.com/apache/solr/pull/827#discussion_r861633358
##########
solr/core/src/java/org/apache/solr/search/join/ChildFieldValueSourceParser.java:
##########
@@ -133,6 +134,7 @@ public SortField getSortField(boolean reverse) {
@Override
public FieldComparator<?> getComparator(int numHits, int sortPos) {
final FieldComparator<?> comparator = super.getComparator(numHits,
sortPos);
+ // SOLR-16172 Returning the default comparator fixes the crash, why
was this needed?
return type == Type.STRING
? new BytesToStringComparator((FieldComparator<BytesRef>)
comparator)
: comparator;
Review Comment:
@mkhludnev Why was this custom BytesToStringComparator needed? Removing it
fixes this bug...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
