risdenk commented on code in PR #825:
URL: https://github.com/apache/solr/pull/825#discussion_r862045671
##########
solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java:
##########
@@ -198,54 +198,84 @@ public void testCreate() throws Exception {
@Test
public void testCreateWithTrust() throws Exception {
String configsetName = "regular";
- String configsetSuffix = "testCreateWithTrust";
- String configsetSuffix2 = "testCreateWithTrust2";
- uploadConfigSetWithAssertions(configsetName, configsetSuffix, "solr");
- uploadConfigSetWithAssertions(configsetName, configsetSuffix2, null);
+ String trustedConfigsetSuffix = "testCreateWithTrustTrusted";
+ String untrustedConfigsetSuffix = "testCreateWithTrustUntrusted";
+ uploadConfigSetWithAssertions(configsetName, trustedConfigsetSuffix,
"solr");
+ uploadConfigSetWithAssertions(configsetName, untrustedConfigsetSuffix,
null);
try (SolrZkClient zkClient =
new SolrZkClient(
cluster.getZkServer().getZkAddress(), AbstractZkTestCase.TIMEOUT,
45000, null)) {
- assertTrue(isTrusted(zkClient, configsetName, configsetSuffix));
- assertFalse(isTrusted(zkClient, configsetName, configsetSuffix2));
+ assertTrue(isTrusted(zkClient, configsetName, trustedConfigsetSuffix));
+ assertFalse(isTrusted(zkClient, configsetName,
untrustedConfigsetSuffix));
Review Comment:
The comments/naming were updated here since it was a PITA to reason through
configset and configset2. This hopefully makes it clearer for the next person.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
