magibney commented on PR #841: URL: https://github.com/apache/solr/pull/841#issuecomment-1119873442
LGTM. I was looking at SOLR-16046 as well and opened #842, which I think should complement this PR nicely. One thing I found myself wondering, wrt the `killer` thread as it exists on `main` at the moment (and as it has existed since its inception): why is it a separate thread at all? ```java Thread t = new Thread(() -> doStuff()); t.start(); t.join(); ``` ... why not just do?: ```java doStuff(); ``` It should execute in the same order, unless there's something "magical" about this being done from a different thread? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
