janhoy commented on code in PR #807:
URL: https://github.com/apache/solr/pull/807#discussion_r869584282
##########
dev-tools/scripts/releaseWizard.yaml:
##########
@@ -955,37 +955,36 @@ groups:
id: stage_maven
title: Stage the maven artifacts for publishing
vars:
+ git_sha: '{{ build_rc.git_rev | default("<git_sha>", True) |
truncate(7,true,"") }}'
dist_folder: solr-{{ release_version }}-RC{{ rc_number }}-rev-{{
build_rc.git_rev | default("<git_rev>", True) }}
commands: !Commands
root_folder: '{{ git_checkout_folder }}'
confirm_each_command: true
commands_text: In the source checkout do the following (note that this
step will prompt you for your Apache LDAP credentials)
commands:
- !Command
- cmd: ant clean stage-maven-artifacts -Dmaven.dist.dir={{
[dist_file_path, dist_folder, 'solr', 'maven'] | path_join }}
-Dm2.repository.id=apache.releases.https -Dm2.repository.url={{
m2_repository_url }}
+ cmd: bash dev-tools/scripts/upload-maven.sh -u {{ gpg.apache_id }}
-v {{ release_version }} -c {{ git_sha }} -d "{{ [dist_file_path, dist_folder,
'solr', 'maven'] | path_join }}"
+ tee: true
logfile: publish_solr_maven.log
post_description: The artifacts are not published yet, please proceed with
the next step to actually publish!
- !Todo
id: publish_maven
depends: stage_maven
title: Publish the staged maven artifacts
+ vars:
+ git_sha: '{{ build_rc.git_rev | default("<git_sha>", True) |
truncate(7,true,"") }}'
Review Comment:
This is the second time we need "short" git-sha. Perhaps `build_rc` should
instead persist a `git_rev_short` variable?
##########
dev-tools/scripts/releaseWizard.yaml:
##########
@@ -955,37 +955,36 @@ groups:
id: stage_maven
title: Stage the maven artifacts for publishing
vars:
+ git_sha: '{{ build_rc.git_rev | default("<git_sha>", True) |
truncate(7,true,"") }}'
dist_folder: solr-{{ release_version }}-RC{{ rc_number }}-rev-{{
build_rc.git_rev | default("<git_rev>", True) }}
commands: !Commands
root_folder: '{{ git_checkout_folder }}'
confirm_each_command: true
commands_text: In the source checkout do the following (note that this
step will prompt you for your Apache LDAP credentials)
commands:
- !Command
- cmd: ant clean stage-maven-artifacts -Dmaven.dist.dir={{
[dist_file_path, dist_folder, 'solr', 'maven'] | path_join }}
-Dm2.repository.id=apache.releases.https -Dm2.repository.url={{
m2_repository_url }}
+ cmd: bash dev-tools/scripts/upload-maven.sh -u {{ gpg.apache_id }}
-v {{ release_version }} -c {{ git_sha }} -d "{{ [dist_file_path, dist_folder,
'solr', 'maven'] | path_join }}"
Review Comment:
I believe perhaps `shell: true` on `!Command` object is an alternative to
explicitly calling `bash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
