gus-asf commented on code in PR #864:
URL: https://github.com/apache/solr/pull/864#discussion_r874277009
##########
solr/core/src/test/org/apache/solr/cloud/CreateRoutedAliasTest.java:
##########
@@ -231,7 +217,106 @@ public void testV1() throws Exception {
assertNotNull(meta);
assertEquals("evt_dt", meta.get("router.field"));
assertEquals("_default",
meta.get("create-collection.collection.configName"));
- assertEquals(null, meta.get("start"));
+ assertNull(meta.get("start"));
+ }
+
+ @Test
+ public void testUpdateRoudetedAliasDoesNotChangeCollectionList() throws
Exception {
+
+ final String aliasName = getSaferTestName();
+ Instant start = Instant.now().truncatedTo(ChronoUnit.HOURS); // mostly
make sure no millis
+ createTRAv1(aliasName, start);
+
+ String initialCollectionName =
+ TimeRoutedAlias.formatCollectionNameFromInstant(aliasName, start);
+ assertCollectionExists(initialCollectionName);
+
+ // Note that this is convenient for the test because it imples a different
collection name, but
+ // doing this is an advanced operation, typically preceded by manual
collection creations and
+ // manual
Review Comment:
ah didn't catch this after I did spotless apply thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
