gerlowskija opened a new pull request, #873: URL: https://github.com/apache/solr/pull/873
# Description Prior to this commit, V2HttpCall populated the "operationName" of tracing spans differently depending on whether the API was implemented as an AnnotatedApi or not. A special code path for AnnotatedApi's had the operationName come primarily from the path value specified on the @Endpoint annotation. This works well for AnnotatedApis registered at the CoreContainer level, but actually produces the wrong path for AnnotatedApis registered on individual cores. # Solution This commit removes this optimized code path, so that per-core AnnotatedApis produce spans consistent with everything else. # Tests Relying primarily on existing tests in TestDistributedTracing. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
