alessandrobenedetti commented on code in PR #872:
URL: https://github.com/apache/solr/pull/872#discussion_r879218293
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -500,7 +500,7 @@ protected int compare(int i, int j) {
// :TODO: would be simpler to always serialize every position of
SortField[]
if (type == SortField.Type.SCORE || type == SortField.Type.DOC)
continue;
- FieldComparator<?> comparator = sortField.getComparator(1, 0);
+ FieldComparator<?> comparator = sortField.getComparator(1, true);
Review Comment:
https://issues.apache.org/jira/browse/LUCENE-10377
The sort position was just used to check if it was equal to 0. In that
scenario enable skipping was activated.
So the expressions are indeed equivalent, resolving the conversation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
