epugh commented on code in PR #895:
URL: https://github.com/apache/solr/pull/895#discussion_r890307463
##########
solr/core/src/test/org/apache/solr/handler/admin/V2ConfigAPIMappingTest.java:
##########
@@ -38,41 +40,54 @@ public boolean isCoreSpecific() {
@Override
public void populateApiBag() {
apiBag.registerObject(new GetConfigAPI(getRequestHandler()));
+ apiBag.registerObject(new ModifyConfigComponentAPI(getRequestHandler()));
+ apiBag.registerObject(new ModifyParamSetAPI(getRequestHandler()));
}
// GET /v2/c/collectionName/config is a pure pass-through to the underlying
request handler
@Test
public void testGetAllConfig() throws Exception {
- assertAnnotatedApiExistsForGET("/config");
+ assertAnnotatedApiExistsFor("GET", "/config");
}
// GET /v2/collectionName/config/<component> is a pure pass-through to the
underlying request
// handler. Just check
// the API lookup works for a handful of the valid config "components".
@Test
public void testGetSingleComponentConfig() throws Exception {
- assertAnnotatedApiExistsForGET("/config/overlay");
- assertAnnotatedApiExistsForGET("/config/query");
- assertAnnotatedApiExistsForGET("/config/jmx");
- assertAnnotatedApiExistsForGET("/config/requestDispatcher");
- assertAnnotatedApiExistsForGET("/config/znodeVersion");
- assertAnnotatedApiExistsForGET("/config/luceneMatchVersion");
+ assertAnnotatedApiExistsFor("GET", "/config/overlay");
Review Comment:
These actually read nicer for me ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
