gerlowskija opened a new pull request, #897:
URL: https://github.com/apache/solr/pull/897
# Description
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API properties. Many security APIs
remain on the "old" framework.
# Solution
This commit converts the APIs from the cluster.security.authentication
and cluster.security.authorization apispec files to the "new" framework.
Several other security apispec files still remain, including:
- cluster.security.BasicAuth.Commands
- cluster.security.JwtAuth.Commands
- cluster.security.MultiPluginAuth.Commands
- cluster.security.RuleBasedAuthorization
- cluster.security.authentication.Commands
- cluster.security.authorization.Commands
The first four entries in the list above are plugin-specific commands
for the `POST /cluster/security/[authentication|authorization]`
endpoints. The last two entries (c.s.authentication.Commands and
c.s.authorization.Commands) are fallbacks for the POST endpoints, to
cover the case where no authc/authz plugins are defined. It's unclear
whether or not these are needed going forward.
The aim is to convert all of these apispec files in this PR.
# Tests
None yet, but I intend to add some prior to merging.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms
to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
