alessandrobenedetti commented on code in PR #910:
URL: https://github.com/apache/solr/pull/910#discussion_r913070148
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -142,8 +134,8 @@ public VectorSimilarityFunction getSimilarityFunction() {
return similarityFunction;
}
- public String getCodecFormat() {
- return codecFormat;
+ public String getAlgorithm() {
+ return algorithm;
Review Comment:
Hi @cpoerschke ,
I thought I responded here as well but I managed to forget...
So, thanks for the suggestion, and in certain scenarios I would agree but
being an "experimental" feature I think we can just keep it simple and do that
here in this pull request.
In this way, we'll avoid the complexity of having to create another pull
request immediately after (and it's a matter of 1 version or another anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
