sonatype-lift[bot] commented on code in PR #753:
URL: https://github.com/apache/solr/pull/753#discussion_r914326117


##########
solr/webapp/web/js/angular/controllers/schema.js:
##########
@@ -289,6 +302,42 @@ solrAdminApp.controller('SchemaController',
                }
             });
         }
+        $scope.toggleManipulateFieldType = function() {
+            if ($scope.showManipulateFieldType) {
+                $scope.hideAll();
+            } else {
+                $scope.hideAll();
+                $scope.showManipulateFieldType = true;
+
+                $scope.adding = "fieldType";
+
+                $scope.fieldTypeObj = ""
+                delete $scope.addErrors;
+            }
+            $scope.fieldTypeManipulationOptions = 
getFieldTypeManipulationOptions();;

Review Comment:
   *no-extra-semi:*  Unnecessary semicolon.
   
   Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
   Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the 
above finding from this PR.
   Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all 
the findings from this PR and from the status bar in Github.
   
   When talking to LiftBot, you need to **refresh** the page to see its 
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get 
to know more about LiftBot commands.
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=291886500&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=291886500&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=291886500&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=291886500&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=291886500&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to