cpoerschke commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r915025303
##########
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##########
@@ -352,8 +349,8 @@ public void testEmptyLineBehaviourExcel() throws Exception {
{""}
};
String code;
Review Comment:
```suggestion
```
##########
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##########
@@ -352,8 +349,8 @@ public void testEmptyLineBehaviourExcel() throws Exception {
{""}
};
String code;
- for (int codeIndex = 0; codeIndex < codes.length; codeIndex++) {
- code = codes[codeIndex];
+ for (String s : codes) {
+ code = s;
Review Comment:
```suggestion
for (String code : codes) {
```
##########
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##########
@@ -372,8 +369,8 @@ public void testEmptyLineBehaviourCSV() throws Exception {
{"hello", ""} // CSV Strategy ignores empty lines
};
String code;
Review Comment:
```suggestion
```
##########
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##########
@@ -227,10 +227,10 @@ public void testGetLine() throws IOException {
public void testNextValue() throws IOException {
CSVParser parser = new CSVParser(new StringReader(code));
String tmp = null;
- for (int i = 0; i < res.length; i++) {
- for (int j = 0; j < res[i].length; j++) {
+ for (String[] re : res) {
+ for (int j = 0; j < re.length; j++) {
Review Comment:
```suggestion
for (String r : re) {
```
##########
solr/core/src/test/org/apache/solr/internal/csv/CSVParserTest.java:
##########
@@ -372,8 +369,8 @@ public void testEmptyLineBehaviourCSV() throws Exception {
{"hello", ""} // CSV Strategy ignores empty lines
};
String code;
- for (int codeIndex = 0; codeIndex < codes.length; codeIndex++) {
- code = codes[codeIndex];
+ for (String s : codes) {
+ code = s;
Review Comment:
```suggestion
for (String code : codes) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
