madrob commented on code in PR #909:
URL: https://github.com/apache/solr/pull/909#discussion_r915422007
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -540,7 +627,7 @@ private void constructState(Set<String> changedCollections)
{
log.debug(
"clusterStateSet: interesting [{}] watched [{}] lazy [{}] total
[{}]",
collectionWatches.keySet().size(),
- watchedCollectionStates.keySet().size(),
+ collectionWatches.activeCollections().size(),
Review Comment:
You already have a method that gets all the names (activeCollections).
Having two methods for different things is fine, even if one can be implemented
in terms of the other because we are able to make it so much cleaner for the
more common use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
