epugh commented on PR #927: URL: https://github.com/apache/solr/pull/927#issuecomment-1178118429
> Even if a logger is unused, I would still leave it in. I was really hoping that I could just use the logger declared in the base class, so for `TestRandomFaceting`, use the `log` declared by `SolrTestCaseJ4`, but it doesn't work, you don't get the right message. Even though the call was in `TestRandomFaceting`, the output refers to where it was defined: ``` o.a.s.SolrTestCaseJ4 HI There from log2 ``` It feels sort of haphazard that the log is on some unit tests but not others.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
