epugh commented on code in PR #927:
URL: https://github.com/apache/solr/pull/927#discussion_r917316058
##########
solr/core/src/test/org/apache/solr/handler/TestSolrConfigHandlerConcurrent.java:
##########
@@ -97,12 +96,7 @@ public void test() throws Exception {
assertTrue(collectErrors.toString(), success);
}
- private void invokeBulkCall(
- String cacheName,
- List<String> errs,
- // TODO this is unused - is that a bug?
Review Comment:
I * think* that this todo was introduced in SOLR-15385 RawTypes Part VI, and
was a reminder to check. I ran the tests and they pass with this change... so
based on that, inclined to keep the change and be happy that the TODO can be
removed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
