[ 
https://issues.apache.org/jira/browse/SOLR-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566345#comment-17566345
 ] 

ASF subversion and git services commented on SOLR-16255:
--------------------------------------------------------

Commit 49ae2f0acfddfafe1fb9974d5da764a3e7756e0a in solr's branch 
refs/heads/main from Bruno Roustant
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=49ae2f0acfd ]

SOLR-16255: Introduce DirectUpdateHandler2#shouldCommit.



> Introduce DirectUpdateHandler2#shouldCommit
> -------------------------------------------
>
>                 Key: SOLR-16255
>                 URL: https://issues.apache.org/jira/browse/SOLR-16255
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Bruno Roustant
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently DirectUpdateHandler2 checks IndexWriter.hasUncommittedChanges() 
> before effectively calling IndexWriter.commit().
> It is also possible for the user to provide custom commit metadata in the 
> CommitUpdateCommand.commitData field.
> The proposed change is to move the check to 
> IndexWriter.hasUncommittedChanges() in a new protected method 
> DirectUpdateHandler2.shouldCommit(), which would also check (logical or) if 
> the CommitUpdateCommand contains user defined commit metadata. It becomes 
> possible to commit without change, but with user defined commit metadata.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to