cpoerschke commented on code in PR #938:
URL: https://github.com/apache/solr/pull/938#discussion_r922269585
##########
solr/core/src/test/org/apache/solr/handler/admin/SolrEnvironmentTest.java:
##########
@@ -31,29 +32,30 @@ public void parseWrongKey() {
@Test
public void parsePredefined() {
- assertEquals("prod", SolrEnvironment.parse("prod").getCode());
+ Assert.assertEquals("prod", SolrEnvironment.parse("prod").getCode());
Review Comment:
Could we maybe also do `import static org.junit.Assert.assertEquals` so that
`assertEquals` and `assertNull` usage 'looks' consistent stylistically?
```suggestion
assertEquals("prod", SolrEnvironment.parse("prod").getCode());
```
##########
solr/core/src/java/org/apache/solr/parser/QueryParser.java:
##########
@@ -2,22 +2,21 @@
/* Generated By:JavaCC: Do not edit this line. QueryParser.java */
package org.apache.solr.parser;
+import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.queryparser.charstream.CharStream;
+import org.apache.lucene.queryparser.charstream.FastCharStream;
+import org.apache.lucene.search.BooleanClause;
+import org.apache.lucene.search.Query;
+import org.apache.solr.search.QParser;
+import org.apache.solr.search.SyntaxError;
+
import java.io.StringReader;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
-import org.apache.lucene.analysis.Analyzer;
-import org.apache.lucene.search.BooleanClause;
-import org.apache.lucene.search.Query;
-import org.apache.solr.search.SyntaxError;
-import org.apache.solr.search.QParser;
-
-import org.apache.lucene.queryparser.charstream.CharStream;
-import org.apache.lucene.queryparser.charstream.FastCharStream;
-
Review Comment:
minor: technically not wildcard import removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
