danrosher commented on code in PR #940: URL: https://github.com/apache/solr/pull/940#discussion_r922325966
########## solr/core/src/java/org/apache/solr/search/function/distance/NVector.java: ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.search.function.distance; + +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.queries.function.FunctionValues; +import org.apache.lucene.queries.function.ValueSource; +import org.apache.lucene.queries.function.docvalues.DoubleDocValues; +import org.apache.lucene.queries.function.valuesource.MultiValueSource; +import org.apache.lucene.search.IndexSearcher; +import org.apache.solr.common.SolrException; + +import java.io.IOException; +import java.util.Map; + +import static org.apache.solr.util.NVectorUtil.NVectorDist; + +public class NVector extends ValueSource { + + private final MultiValueSource p1; + private final MultiValueSource p2; Review Comment: They are nvectors, I've changed to something more meaningful, I was told about them recently from a prior employer https://en.wikipedia.org/wiki/N-vector, and thought if we can pre-calculate and store the vectors, and have a fast impl for acos then this can lead to a fast distance calculation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
