epugh commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925758259
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
The static import seems better than the explicit
`MatcherAssert.assertThat`..... So... How do we get a decision on this?
Is there anything in our code style guide that would guide us to one of these
choices???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
