[
https://issues.apache.org/jira/browse/SOLR-16304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571043#comment-17571043
]
Mike Drob commented on SOLR-16304:
----------------------------------
After spending some time at this, I've settled on a few patterns so far...
*1. No Slow tests in solrj module.* Even if they're slow, they should probably
be run every time, and if somebody cares about it they can work to speed them
up. I've done this with a few already and cut their time from 60s to 30s on my
machine.
*2. If a test class is already Nightly* or Monster or AwaitsFix or Ignore then
it doesn't need to be Slow as well.
3. For non-nightly runs, anything inheriting from
*BaseDistributedSearchTestCase will be call {{fixShardCount(2)}}*. Previously a
lot of these tests would run the repeat rule and test with 1,2,3,... shards all
in the same run. We can push that to nightly, I believe.
*4. Anything "fast enough" gets dropped from Slow.* This was generally under
15s on my machine, but sometimes I would accept a 20s test as well.
*5. Any tests over 2 minutes* get moved to Nightly.
My command for running only the slow tests:
{code}
gw test $(git grep -l LuceneTestCase.Slow | grep -o -e '[A-Za-z0-9]*[.]java' |
cut -d. -f1 | awk -v ORS=" " '{print "--tests", $1 }')
{code}
is down to 44 test classes and completes in just over 3m. Previously there were
112 slow tests. It's not really fair to compare runtime from before, since a
lot of them didn't go anywhere, they just got removed from the slow category.
> Stop using @LuceneTestCase.Slow
> -------------------------------
>
> Key: SOLR-16304
> URL: https://issues.apache.org/jira/browse/SOLR-16304
> Project: Solr
> Issue Type: Sub-task
> Reporter: Mike Drob
> Priority: Blocker
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Lucene dropped the {{@Slow}} annotation in LUCENE-10532 so we need to come up
> with a solution if we want to upgrade. We can do one or more of:
> 1. Create our own Slow annotation and wire that into the build instead
> 2. Switch all of the currently Slow tests to use a different annotation
> (maybe Nightly?)
> 3. Make the tests fast (haha, yikes!)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
