gerlowskija commented on code in PR #456:
URL: https://github.com/apache/solr-operator/pull/456#discussion_r930985956
##########
controllers/controller_utils_test.go:
##########
@@ -506,36 +507,32 @@ func filterVarsByName(envVars []corev1.EnvVar, f
func(string) bool) []corev1.Env
}
func testPodEnvVariables(expectedEnvVars map[string]string, foundEnvVars
[]corev1.EnvVar, additionalOffset ...int) {
- testGenericPodEnvVariables(expectedEnvVars, foundEnvVars, "SOLR_OPTS",
resolveOffset(additionalOffset))
+ testPodEnvVariablesWithGomega(Default, expectedEnvVars, foundEnvVars,
resolveOffset(additionalOffset))
}
func testPodEnvVariablesWithGomega(g Gomega, expectedEnvVars
map[string]string, foundEnvVars []corev1.EnvVar, additionalOffset ...int) {
- testGenericPodEnvVariablesWithGomega(g, expectedEnvVars, foundEnvVars,
"SOLR_OPTS", resolveOffset(additionalOffset))
-}
-
-func testMetricsPodEnvVariables(expectedEnvVars map[string]string,
foundEnvVars []corev1.EnvVar, additionalOffset ...int) {
Review Comment:
These methods were all able to be merged, as the only thing differentiating
them previously was the env-var that they required to be last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
