gerlowskija opened a new pull request, #955:
URL: https://github.com/apache/solr/pull/955
# Description
Prior to this commit, the logic for all configset APIs lived in
ConfigSetsHandler. This made the file slightly unwieldy, and made it easy for
the v1 APIs to change without updates to their v2 counterparts.
# Solution
This PR moves the logic for each configset endpoint into its own (v2
annotated) API class. These API classes are then called from
ConfigSetsHandler. This ensures that the v2 API is kept abreast of any changes
in the configset logic.
# Tests
Mostly leans on the existing TestConfigSetsAPI test, which has surprisingly
solid coverage of both the v1 and v2 APIs.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms
to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
