cpoerschke commented on code in PR #954:
URL: https://github.com/apache/solr/pull/954#discussion_r933306494
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKGEquiv.java:
##########
@@ -103,7 +103,7 @@ public class TestCloudJSONFacetSKGEquiv extends
SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKG.java:
##########
@@ -114,7 +114,7 @@ public class TestCloudJSONFacetSKG extends
SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
##########
solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetJoinDomain.java:
##########
@@ -88,7 +88,7 @@ public class TestCloudJSONFacetJoinDomain extends
SolrCloudTestCase {
private static final ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
@BeforeClass
- private static void createMiniSolrCloudCluster() throws Exception {
+ public static void createMiniSolrCloudCluster() throws Exception {
// sanity check constants
Review Comment:
```suggestion
// check constants
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
