HoustonPutman commented on code in PR #957:
URL: https://github.com/apache/solr/pull/957#discussion_r934721683


##########
solr/modules/s3-repository/src/test/org/apache/solr/s3/S3IncrementalBackupTest.java:
##########
@@ -89,6 +90,12 @@ public static void setupClass() throws Exception {
     System.setProperty("aws.accessKeyId", "foo");
     System.setProperty("aws.secretAccessKey", "bar");
 
+    // Make sure we don't pollute with defaults from ~/.aws/config or 
credentials

Review Comment:
   Does `AbstractS3ClientTest` also need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to