markrmiller commented on PR #585: URL: https://github.com/apache/solr/pull/585#issuecomment-1201673183
I don’t know that modifying jetty.xml is that common. If the only case you were affected is if you had, I would just say release note it. The problem is, you don’t need to have modified it. The version we shipped with won’t work, so you would have to overwrite that file on upgrade to avoid the issue. If that is the standard upgrade process being used, then perhaps this is less of an issue. What I imagine is a typical install layout that includes your Solr core directories and indexes and a point release upgrade would be commonly done by leaving your config and directories in place and just replacing the binary jars. I don’t point release upgrade though, so maybe it’s normal to do a process that blows the jetty config files away? Of course you could release now that you need to. My concern is that to my knowledge we have not had a release note that if not followed means a standard upgrade process would result in Jetty failing to start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
