thelabdude commented on code in PR #461:
URL: https://github.com/apache/solr-operator/pull/461#discussion_r934964702


##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1523,6 +1523,14 @@ type SolrTLSOptions struct {
        // This option is typically used with 
`spec.updateStrategy.restartSchedule` to restart Solr pods before the mounted 
TLS cert expires.
        // +optional
        MountedTLSDir *MountedTLSDirectory `json:"mountedTLSDir,omitempty"`
+
+       // Path on the Solr image to your JVM's truststore to merge with an 
external truststore.
+       // If supplied, Solr will be configured to use the merged truststore.
+       // The truststore for the JVM in the default Solr image is: 
$JAVA_HOME/lib/security/cacerts
+       MergeJavaTruststore string `json:"mergeJavaTrustStore,omitempty"`

Review Comment:
   No, nvm all that `volumesAndMounts` doesn't include vols & mounts for the 
`mountedTLSDir` option. So this option is not going to work with 
`mountedTLSDir`.
   
   So maybe we just punt on this feature for 0.6 and solve it using an init-db 
script instead? There's already some code in place for mounting a script into 
the init-db.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to